/juju

Resource lister refactor. #7682

Merged
merged 1 commit into from Jul 28, 2017

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anastasiamac @jujubot @axw
@anastasiamac
Member

anastasiamac commented Jul 28, 2017

Description of change

This PR changes constructor for list charm resources command to accept a ResourceLister.
It is needed to ensure that we can test the command easily without test patching.

QA steps

All unit tests still pass and 'juju charm resources...' command does not panic.

Documentation changes

n/a as it is an internal change.

Bug reference

Progress PR for https://bugs.launchpad.net/juju/+bug/1706809
@axw

axw approved these changes Jul 28, 2017
View changes

@anastasiamac
Member

anastasiamac commented Jul 28, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Jul 28, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 1fa72fd into juju:develop Jul 28, 2017
1 check passed

1 check passed

github-check-merge-juju Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@anastasiamac anastasiamac deleted the anastasiamac:resource-lister-refactor branch Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment