Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Register resource commands as per convention. #7686
Conversation
babbageclunk
approved these changes
Jul 31, 2017
This looks great thanks - I've been bitten by the fact that the resource commands live somewhere else before.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 5a46f60
into
juju:develop
Jul 31, 2017
1 check passed
github-check-merge-juju
Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
anastasiamac
deleted the
anastasiamac:resource-cmd-register
branch
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedJul 31, 2017
Description of change
This PR moves registration of resource commands - 'juju attach' and 'juju resources' - into common framework.
QA steps
All unit tests run successfully. 'juju attach' and 'juju resources' are in the list of 'juju help commands' and behave as previously.
Documentation changes
n/a as this is a refactoring exercise.
Bug reference
Contributes to fixing https://bugs.launchpad.net/juju/+bug/1706809