Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Order resources list. #7688
Conversation
|
$$merge$$ Thank you for review, @babbageclunk \o/ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit e98ee66
into
juju:develop
Jul 31, 2017
1 check passed
github-check-merge-juju
Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details
anastasiamac
deleted the
anastasiamac:list-resources-deterministic-order
branch
Jul 31, 2017
|
This change may require documentation update. |
pmatulis
commented
Sep 15, 2017
|
@anastasiamac Nothing to do here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedJul 31, 2017
Description of change
Resources are returned in a map which means that display order is not guaranteed between runs.
This PR ensures that at presentation level, list of resources is always sorted by name in alphabetical order.
This is a pre-cursor to a PR that adds resources featuretest.
QA steps
Expected output should be consistently ordered by name.
Documentation changes
n/a
I could not find any juju documentation where 'juju charm resources' command had an output with more than one resource. If such pages exist, they may need to be updated.
Bug reference
Contributes to https://bugs.launchpad.net/juju/+bug/1706809