Order resources list. #7688

Merged
merged 1 commit into from Jul 31, 2017

Conversation

Projects
None yet
4 participants
Member

anastasiamac commented Jul 31, 2017

Description of change

Resources are returned in a map which means that display order is not guaranteed between runs.
This PR ensures that at presentation level, list of resources is always sorted by name in alphabetical order.

This is a pre-cursor to a PR that adds resources featuretest.

QA steps

  1. bootstrap
  2. run 'juju charm resources' for a charm with multiple resources, several times
    Expected output should be consistently ordered by name.

Documentation changes

n/a

I could not find any juju documentation where 'juju charm resources' command had an output with more than one resource. If such pages exist, they may need to be updated.

Bug reference

Contributes to https://bugs.launchpad.net/juju/+bug/1706809

Member

anastasiamac commented Jul 31, 2017

$$merge$$

Thank you for review, @babbageclunk \o/

Contributor

jujubot commented Jul 31, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit e98ee66 into juju:develop Jul 31, 2017

1 check passed

github-check-merge-juju Use !!.*!! to request another build. IE, !!build!!, !!retry!!
Details

@anastasiamac anastasiamac deleted the anastasiamac:list-resources-deterministic-order branch Jul 31, 2017

Member

anastasiamac commented Aug 23, 2017

@pmatulis,

This change may require documentation update.

@anastasiamac Nothing to do here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment