Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Remove model count based on cache. #7716
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
merged commit 0f377ec
into
juju:develop
Aug 10, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
anastasiamac
deleted the
anastasiamac:cached-model-count-lp1693843
branch
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedAug 9, 2017
Description of change
We were reporting redundant and incorrect information to the user when they were trying to access information about a 'currently in-focus' model that no longer exists. Since we are directing users to 'juju models', which will correctly display all accessible models on the current controller, there is no longer a need to tell users how many models were previously accessed to on this controller. This model count get quickly out of date, especially when models are being created/destroyed using different clients.
This PR removes misleading part of the error message.
QA steps
Expected error message:
WARNING cannot read current model: current model for controller not found
ERROR model <full name for 'trial2' model> has been removed from the controller, run 'juju models' and switch to one of them.
Documentation changes
If this error message has been mentioned in documents explicitly, it will need to be updated.
Bug reference
https://bugs.launchpad.net/juju/+bug/1693843