/juju

Handle subordinates with multiple principals. #7722

Merged
merged 3 commits into from Aug 10, 2017
+75 −2

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@howbazaar @jujubot @babbageclunk
@howbazaar
Owner

howbazaar commented Aug 9, 2017 •
Edited 1 time

The state.Export function was failing in situations where there was a subordinate application related to more than one principal. This is a common situation in production deployments.

QA steps

Deploy the following to a model:

$ juju deploy prometheus
$ juju deploy haproxy
$ juju deploy nrpe-external-master --series xenial --force
$ juju relate nrpe-external-master prometheus
$ juju relate nrpe-external-master haproxy
# wait until all deployed
$ juju dump-model
@babbageclunk

babbageclunk approved these changes Aug 10, 2017
View changes

Looks good!

@howbazaar
Owner

howbazaar commented Aug 10, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Aug 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 21b7ba6 into juju:2.2 Aug 10, 2017
1 check failed

1 check failed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details

@howbazaar howbazaar deleted the howbazaar:2.2-migration-subordinate-relations branch Aug 10, 2017

@Veebers Veebers referenced this pull request Aug 11, 2017

Merged

Update model migration test to include subordinates for migration. #7732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment