/juju

Remove old service reference. #7725

Merged
merged 2 commits into from Aug 10, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@anastasiamac @jujubot @babbageclunk
@anastasiamac
Member

anastasiamac commented Aug 10, 2017

Description of change

Hook 'status-set' accepted both --service and --application as a parameter for an application.
This is a historic renaming weight. Juju 2.3 is a great time to support only --application.

QA steps

  1. juju run --unit ubuntu/0 'status-set --help'
    [Should only display application as an option]

Documentation changes

'status-set' help updated.

Bug reference

https://bugs.launchpad.net/juju/+bug/1626110
@babbageclunk

babbageclunk approved these changes Aug 10, 2017
View changes

Nice. Worth renaming the service attribute to application at the same time?

@anastasiamac
Member

anastasiamac commented Aug 10, 2017

Done :)
@anastasiamac
Member

anastasiamac commented Aug 10, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Aug 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 26d090e into juju:develop Aug 10, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@anastasiamac anastasiamac deleted the anastasiamac:remove-service-lp1626110 branch Aug 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment