Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
state: Add support for CAAS models #7770
Conversation
| + if err != nil { | ||
| + return nil, nil, errors.Trace(err) | ||
| + } | ||
| + prereqOps = append(prereqOps, assertCloudRegionOp) | ||
| } |
mikemccracken
Aug 22, 2017
Member
Should we do something here if the type is CAAS? Maybe if it's CAAS we should be checking that args.CloudRegion should be ""?
| + c.Assert(model.ControllerTag(), gc.Equals, s.State.ControllerTag()) | ||
| + c.Assert(model.Owner(), gc.Equals, owner) | ||
| + c.Assert(model.Name(), gc.Equals, "testing") | ||
| + c.Assert(model.Life(), gc.Equals, state.Alive) |
mikemccracken
Aug 22, 2017
Member
Should we test CloudRegion here? I'm assuming that for now we say that CAAS clouds don't support regions, so the CAAS model's region should always be ""
mjs
added some commits
Aug 22, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 3d45aab
into
juju:develop
Aug 23, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
mjs
deleted the
mjs:caas-model-type
branch
Aug 23, 2017
mikemccracken
referenced this pull request
Oct 31, 2017
Closed
RFC: Add CAAS cloud config to model defaults for default region #7995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedAug 22, 2017
Description of change
If the CAAS featureflag is enabled, allow models to be created of type "caas". The model type must be specified when creating a model.
Migration support for model type field has also been added. This doesn't mean that migrations will "just work" for CAAS models but these changes are required to support that anyway.
This change caused plenty of tedious fallout in tests throughout Juju.
QA steps
(coming)
Documentation changes
N.A.
Bug reference
N.A.