Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
apiserver: Removed remaining ForModel calls #7781
Conversation
mjs
added some commits
Aug 24, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 7925396
into
juju:develop
Aug 24, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
mjs
deleted the
mjs:apiserver-ForModel-removal
branch
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mjs commentedAug 24, 2017
Description of change
Two apiserver facades were still using ForModel. ForModel is slow and
resource hungry. It is better to use the apiserver's StatePool.
The affected facades are apiserver/facades/client/controller and
apiserver/facades/controller/metricsmanager.
QA steps
This is a fairly safe change. Tested a model migration to be sure.
Documentation changes
N.A.
Bug reference
N.A.