Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Reset password, api version check. #7804
Conversation
| } | ||
| + defer c.api.Close() |
axw
Aug 29, 2017
Member
it was in the right place, in the block that created the client (NewUserManagerAPIClient). please move it back
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit f30dc36
into
juju:develop
Aug 29, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
anastasiamac
deleted the
anastasiamac:reset-pwd-api-version
branch
Aug 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
anastasiamac commentedAug 28, 2017
Description of change
Reset password functionality was only introduced on UserManager v2. This means that older juju controllers will not be able to provide this functionality when used with later clients.
This PR adds an API version check and ensures that api conection is closed after the command has run. Tests have been added and adjusted accordingly.
QA steps
Documentation changes
n/a
Bug reference
n/a