List and show- controllers update client store.

[anastasiamac]

Description of change

Both 'controllers --refresh' and 'show-controller' get full models list for a given controller. Use this as an opportunity to update client store.

Whilst the updates on th commands are straightforward, most of the movement proposed in this PR is in the test since tests were setup in such a way that client side store was re-used to supply data "coming" from the API. Here we separate API data from store data to check that the store is updated.

QA steps

1. Bootstrap
2. modify store file to contain some non-existent models
3. Run 'controllers --refresh', check store has been updated to contain only existent models
4. repeat step 2
5. run 'show-controller' for bootstrapped model and check that the store has been updated correctly

Documentation changes

n/a - internal change

Bug reference

n/a

[axw]

what necessitates this change? why is it OK for the model name above to be unqualified, but not current-model?

[anastasiamac]

This is the outdated test data. We will always store qualified name (and test entries for model names will be updated when store models get updated).

Comparison logic worked ok in tests because we have never written test store data through QualifyingClientStore. Since we update store now as part of running the commands, all model names will be qualified. For current model asterix to be displayed, current model names need to be qualified to start with, otherwise store update will remove them.

[anastasiamac]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju