Relate via #7813
Merged
Relate via #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
approved these changes
Aug 31, 2017
| @@ -218,6 +219,13 @@ func (s stateShim) AddRelation(eps ...state.Endpoint) (Relation, error) { | |||
| return stateRelationShim{r}, nil | |||
| } | |||
|
|
|||
| type RelationNetworks state.RelationNetworks | |||
There was a problem hiding this comment.
I don't see any point to this, state.RelationNetworks is already an interface.
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We now support adding a remote relation and specifying the egress subnets from which outbound traffic will originate. This compliments the existing model wide config attribute "egress-subnets".
The first commit renames the model attribute "egress-cidrs" to "egress-subnets".
The second commit addes the --via support.
The UX is "juju add-relation foo bar --via cidr1,cidr2,..."
QA steps
juju bootstrap aws dbctrl
juju deploy mysql
juju offer mysql:db
From behind a firewall or cgnat:
juju bootstrap lxd mwctrl
juju deploy mediawiki
juju relate mediawiki:db dbctrl:defauly.mysql --via <what's-my-ip>/32
check aws firewall ports and check that media wiki is operational