Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Add egress-address to relation data #7818
Conversation
| @@ -245,7 +245,8 @@ func (w *EgressAddressWatcher) loop() error { | ||
| } | ||
| } | ||
| -func formatAsCIDR(addresses []string) []string { | ||
| +// FormatAsCIDR formats the specified IP address as a CIDR. |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit c2a26df
into
juju:develop
Sep 1, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedSep 1, 2017
•
Edited 1 time
-
wallyworld
Sep 1, 2017
Description of change
Add egress-subnets to relation data.
Also delete some old incorrect code for determining the ingress-address.
The second commit adds an admin override option when saving relation networks. This sets up the state data model for later use, allowing an admin to control what ingress rules are used for a given relation.
QA steps
smoke test CMR scenario