Model firewall rules in state

[wallyworld]

Description of change

Firewall rules are modelled to allow restrictions to be placed on incoming connections to a Juju model. The restrictions may be applied to a well known internet service like SSH, or a Juju defined service like connecting to a controller or to a remote offer. The currently supported services are:

• ssh
• juju controller connections
• connections to workloads defined by juju application offers

Note that the rules are globally applied to a given service - there's no scope to have fine grained rules on a per offer basis for example; rules are applied equally to all application offers.

QA steps

No QA at this stage - just infrastructure.

[axw]

haven't looked enough to +1, but looks good

[axw]

check that they haven't changed, rather than just exist?

[wallyworld]

The thinking here is last one wins, so just checking for existence is ok I think. It's the pattern we tend to use everywhere else.

[axw]

fair enough

[axw]

LGTM, but I'd prefer if FirewallRule was a struct. It doesn't have behaviour, doesn't need to be mocked.

[axw]

Why not just pass around struct values? I don't see any benefit to making this an interface.

[wallyworld]

Ok, changed to structs.

[wallyworld]

$$merge$$

[jujubot]

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju