migration: Don't create invalid relation scopes for subordinates on import #7840

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
3 participants
Member

babbageclunk commented Sep 8, 2017

Description of change

Importing a model that had correct relation scopes for a subordinate with two principals would create invalid relaton scopes, which would cause problems if/when relations were removed after the import. (See bug below for more detail of problems.)

QA steps

  • Deploy a subordinate related to two principals, eg:
ubuntu/0
  telegraf/0
mysql/0
  telegraf/1
  • Removing and re-adding each relation (leaving time for the system to settle at each step) - the associated telegraf unit should go away and come back successfully.
  • Migrate the model to another controller.
  • Remove and re-add each relation as above - the telegraf units should be removed and recreated cleanly.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1715794

Don't create invalid relation scopes for subordinates
Importing a model that had correct relation scopes for a subordinate
with two principals would create invalid relaton scopes, which would
cause problems when relations were removed after the import.

Fixes https://bugs.launchpad.net/juju/+bug/1715794

axw approved these changes Sep 11, 2017

Member

babbageclunk commented Sep 11, 2017

$$merge$$

Contributor

jujubot commented Sep 11, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 7b8ad51 into juju:2.2 Sep 11, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@babbageclunk babbageclunk deleted the babbageclunk:subordinates-import branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment