2.2 bundle include fixes #7848

Merged
merged 4 commits into from Sep 13, 2017

Conversation

Projects
None yet
3 participants
Owner

howbazaar commented Sep 13, 2017

This branch addresses two bugs found in processing bundles, and one that hadn't yet been found.

When the local processing of the include directives came across a machine without a machineSpec, which would happen if nothing was specified, it paniced.

Also, when a bundle was processed as a directory, not a file, then the bundleDir was empty rather than the directory specified. This meant that the bundle was considered a charmstore bundle, not a local bundle, so Verify was called on the bundle rather than VerifyLocal. This would have meant that local resources would fail validation.

QA steps

# Have a local bundle directory (needs bundle.yaml and README.md)
# Make sure there is a machine defined with nothing extra.
juju deploy .

Bug reference

pad.lv/1716462 and pad.lv/1716482

Owner

howbazaar commented Sep 13, 2017

$$merge$$

Contributor

jujubot commented Sep 13, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 78c6ba3 into juju:2.2 Sep 13, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment