Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
2.2 bundle include fixes #7848
Conversation
howbazaar
added some commits
Sep 12, 2017
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 78c6ba3
into
juju:2.2
Sep 13, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
howbazaar commentedSep 13, 2017
This branch addresses two bugs found in processing bundles, and one that hadn't yet been found.
When the local processing of the include directives came across a machine without a machineSpec, which would happen if nothing was specified, it paniced.
Also, when a bundle was processed as a directory, not a file, then the bundleDir was empty rather than the directory specified. This meant that the bundle was considered a charmstore bundle, not a local bundle, so Verify was called on the bundle rather than VerifyLocal. This would have meant that local resources would fail validation.
QA steps
Bug reference
pad.lv/1716462 and pad.lv/1716482