Initial WIP for changes using --existing. #7858

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

Veebers commented Sep 15, 2017

A WIP example of changes we can make to the use of --existing to simplify the use of the feature.

This is open for discussion as it's a suggestion on the direction we could go with this.
Note: this is un-tested at this point and is merely a code example of my suggestions (via email).

This looks conceptually good -- I expect tweaks once tested.

-def add_basic_testing_arguments(parser, using_jes=False, deadline=True,
- env=True):
+def add_basic_testing_arguments(
+ parser, using_jes=False, deadline=True, env=True, existing=False):
@nskaggs

nskaggs Sep 26, 2017

Owner

As mentioned, consider making this with a default of false in the argument, and drop from the method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment