Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Support firewall icmp rules #7969
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit c8f53ae
into
juju:develop
Oct 26, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedOct 26, 2017
Description of change
open/close-port hook tools and the Juju firewaller now support ICMP rules. So a charm can specify it wants to allow ICMP access to its host machine.
QA steps
Deploy the ubuntu charm (on aws)
juju run --unit ubuntu/0 "open-port icmp"
check that the sec group has the icmp rule added
close port and check that the rule is deleted.
Documentation changes
Charm hook tools doc needs updating.