Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Retry when getting a unit's public address when it enters scope #8020
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 7ac444c
into
juju:develop
Nov 3, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedNov 3, 2017
Description of change
When running up a cmr scenario from a script, sometimes the relation could be added before the offering application's machine gets a public address. We add a retry loop to allow for a few attempts to get the public address before falling back to the private one.
QA steps
juju bootstrap aws && juju switch controller && juju deploy cs:~wallyworld/nagios && juju expose nagios && juju offer nagios:monitors && juju switch default && juju deploy ubuntu && juju deploy cs:~wallyworld/nrpe && juju add-relation ubuntu nrpe && juju add-relation nrpe:monitors controller.nagios
Run a few times and ensure the cross model relation connects. It used to fail every so often because only the private address would get selected.