/juju

Handle the case where remove-offer gets a bogus offer #8054

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @axw
@wallyworld
Owner

wallyworld commented Nov 13, 2017

Description of change

When removing an offer what was properly formed but the model didn't exist, we were not catching that error. This fixes that.

QA steps

bootstrap
$ juju remove-offer bogusmode/someoffer
ERROR model "admin/bogusmodel" not found

Bug reference

https://bugs.launchpad.net/juju/+bug/1731812
@axw

axw approved these changes Nov 13, 2017
View changes

@wallyworld
Owner

wallyworld commented Nov 13, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Nov 13, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit e488d78 into juju:develop Nov 13, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment