/juju

mongo: SelectPeer* should not use local addresses #8066

Merged
merged 1 commit into from Nov 14, 2017

Conversation

Reviewers

@jameinel jameinel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @jameinel
@axw
Member

axw commented Nov 14, 2017

Description of change

The mongo.SelectPeer* functions should not
use local addresses, as they will never be
suitable for communicating across machines
to other MongoDB servers. Filter out machine-
local addresses.

QA steps

  1. juju bootstrap localhost
  2. lxc launch ubuntu:xenial x1
  3. lxc launch ubuntu:xenial x2
  4. juju switch controller
  5. juju add-machine ssh:x1.lxd
  6. juju add-machine ssh:x2.lxd
  7. juju enable-ha --to 1,2
    (machines 1 and 2 should eventually become voting replica set members)

Documentation changes

None.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1642618
@axw
Member

axw commented Nov 14, 2017

enable-ha using existing machines breaks agents
@axw
mongo: SelectPeer* should not use local addresses 
The mongo.SelectPeer* functions should not
use local addresses, as they will never be
suitable for communicating across machines
to other MongoDB servers. Filter out machine-
local addresses.

Fixes https://bugs.launchpad.net/juju/+bug/1642618
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
49544ed
@axw
Member

axw commented Nov 14, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Nov 14, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 4b75a1d into juju:develop Nov 14, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
@jameinel
Owner

jameinel commented Nov 14, 2017

mgo tweaks for txn-queue length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment