worker/uniter: fix debug-hooks exit status output #8078

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
3 participants
Member

axw commented Nov 15, 2017

Description of change

Fix the debug-hooks bash scripts to return the
exit status correctly. We previously sent the
script to bash stdin, which meant a $ had to
be escaped; now it's written to disk, and does
not.

QA steps

  1. juju bootstrap && juju deploy ubuntu
  2. juju debug-hooks ubuntu/0
  3. juju config ubuntu hostname=foo
  4. (in debug-hooks) exit 0
    (check juju status output -- unit should be idle/not in error)
  5. juju config ubuntu hostname=bar
  6. (in debug hooks) exit 1
    (check juju status output -- unit should be in error)

Documentation changes

None.

Bug reference

Fixes https://bugs.launchpad.net/juju/+bug/1732233

worker/uniter: fix debug-hooks exit status output
Fix the debug-hooks bash scripts to return the
exit status correctly. We previously sent the
script to bash stdin, which meant a $ had to
be escaped; now it's written to disk, and does
not.

Fixes https://bugs.launchpad.net/juju/+bug/1732233
Member

axw commented Nov 15, 2017

$$merge$$

Contributor

jujubot commented Nov 15, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 14b3ca6 into juju:develop Nov 15, 2017

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment