Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix bug 1728738, don't over write failure status if aborting model migration. #8088
Conversation
|
Can one of the admins verify this patch? |
| @@ -612,7 +617,7 @@ func (w *Worker) doREAP() (coremigration.Phase, error) { | ||
| } | ||
| func (w *Worker) doABORT(targetInfo coremigration.TargetInfo, modelUUID string) (coremigration.Phase, error) { | ||
| - w.setInfoStatus("aborted, removing model from target controller") | ||
| + w.logger.Infof("aborted, removing model from target controller") |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit babb0e1
into
juju:develop
Nov 16, 2017
1 check failed
continuous-integration/jenkins/pr-merge
This commit cannot be built
Details
hmlanigan
deleted the
hmlanigan:bug1728738
branch
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
hmlanigan commentedNov 16, 2017
Description of change
Skip setting migration status when aborting to facilitate finding the cause of the migration failure without hunting in the log file. Do continue to log the abort.
QA steps
Add a migrationmaster wrench with "die-in-export", try to migrate a model. The show-model, migration status should not be "aborted, removing model from target controller".
Documentation changes
N/A
Bug reference
https://bugs.launchpad.net/juju/+bug/1728738