/juju

Romulus doesn't ever talk to the plain juju api. #8114

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Reviewers

@ExternalReality ExternalReality

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jameinel @jujubot @ExternalReality
@jameinel
Owner

jameinel commented Nov 21, 2017

Description of change

It only uses the Wallet Client api, so we don't need this interface. Just a trivial cleanup for something that was importing params and referencing ModelInfo that doesn't actually do anything with it.

QA steps

Nothing should change.

Documentation changes

None

Bug reference

None
@jameinel
Romulus doesn't ever talk to the plain juju api. 
It only uses the Wallet Client api, so we don't need this interface.
9dd28b9
@ExternalReality

ExternalReality approved these changes Nov 21, 2017 • edited
View changes

Unnecessary & Interface Definition removed. LGTM

@jameinel
Owner

jameinel commented Nov 21, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Nov 21, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 04a0e11 into juju:develop Nov 21, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment