Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Do not bounce metrics workers if there's a data error #8119
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 6c170a3
into
juju:develop
Nov 22, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedNov 22, 2017
Description of change
If the metrics collection or sender workers error due to a data encoding or other issue like that, there's no point in bouncing the workers as it won't correct the problem. To make the logs quieter, log at debug level and don't return an error.
QA steps
Create an empty metrics file and check logs.