Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
apiserver: ping presence for other controllers #8122
Conversation
| - // controller machines; they run their own. | ||
| - startPinger = false | ||
| - } | ||
| + // TODO(axw) we shouldn't have to run pingers for |
howbazaar
Nov 23, 2017
Owner
For what its worth, with my new presence work we won't need to run these pingers for any connections.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 774c082
into
juju:develop
Nov 23, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedNov 23, 2017
Description of change
Controllers are not currently guaranteed to
connect to their own API server, so for now
we ping presence for any connected controller.
QA steps
(all controllers should eventually show up as "started")
Without this change, the secondary controllers may stay "down".
Documentation changes
None.
Bug reference
None.