Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Move common hook command logic to worker/common/hooks #8150
Conversation
wallyworld
added some commits
Nov 29, 2017
|
!!build!! |
wallyworld
added some commits
Nov 29, 2017
| +// Copyright 2017 Canonical Ltd. | ||
| +// Licensed under the AGPLv3, see LICENCE file for details. | ||
| + | ||
| +package testing |
axw
Nov 29, 2017
Member
can you please give the package name a bit more context? like "hookstesting". otherwise we'll end up having to alias it (or some other "testing" package) everywhere
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 35fb5d7
into
juju:develop
Nov 29, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
wallyworld commentedNov 29, 2017
•
Edited 2 times
-
wallyworld
Nov 29, 2017
-
wallyworld
Nov 29, 2017
Description of change
A lot of paper shuffling to extract common hook command logic from the uniter package and move it to worker/common/hooks. This will be shared by the jujud operator worker to run its hook commands.
The second commit is a drive by fix for a compile error on Windows.
The third commit adds the operator hook command server.
The fourth commit renames worker/common/hooks to worker/common/hooktools as we will move the uniter runner stuff to a worker/common/hookrunner package next.
QA steps
Bootstrap abd deploy and relate some charms.