Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
worker/caasunitprovisioner: add worker #8169
Conversation
| + } | ||
| +} | ||
| + | ||
| +type applicationWorker struct { |
| + } | ||
| +} | ||
| + | ||
| +type unitWorker struct { |
| + c.Fatal("timed out sending applications change") | ||
| + } | ||
| + | ||
| + workertest.CheckKilled(c, s.unitGetter.watcher) |
wallyworld
Dec 4, 2017
Owner
check the spec watcher also since it should be killed along with the unit watcher when the app goes away?
axw
Dec 4, 2017
Member
no, because we never send a units change - hence there are no unit workers running
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit b3d60ed
into
juju:develop
Dec 4, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedDec 4, 2017
Description of change
Add the CAAS unit provisioner worker.
The worker watches for units in the
model, and watches each unit's
container spec. Later we will call into
the CAAS broker to create or update
the container/pod given the spec.
There is currently no API or broker
implementation backing this, so it
cannot yet be wired up.
QA steps
None - code is not yet wired up.
Documentation changes
None.
Bug reference
None.