Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Implement operator facade apis used to make the hook context #8173
Conversation
axw
reviewed
Dec 5, 2017
Looks fine apart from the change to TestWorkerDownloadsCharm, which I'd like to understand.
| w, err := caasoperator.NewWorker(s.config) | ||
| c.Assert(err, jc.ErrorIsNil) | ||
| defer workertest.CleanKill(c, w) | ||
| s.settingsChanges <- struct{}{} | ||
| + ctx.waitForHooks(c, []string{"config-changed"}) |
wallyworld
Dec 5, 2017
Owner
we need to wait for the hook to fire or else the method calls get the "APIAddresses" called when setting up the hook context
| +} | ||
| + | ||
| +func (c *fakeClient) ProxySettings() (proxy.Settings, error) { | ||
| + c.MethodCall(c, "APIAddresses", nil) |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
wallyworld commentedDec 5, 2017
Description of change
Add the caas operator facade APIs used to make a context factory and wire them up.
QA steps
smoketest a caas deployment