/juju

Rename application config methods #8199

Merged
merged 3 commits into from Dec 11, 2017

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @babbageclunk
@wallyworld
Owner

wallyworld commented Dec 11, 2017

Description of change

Application entity currently has a method called ConfigSettings() which returns the charm's config. We need to introduce non-charm config for the application itself, so rename the method to CharmConfig() to allow for that. Some CAAS facades have their ApplicationConfig() methods renamed to CharmConfig() to allow for the ApplicationConfig() name to be used for the application specific (non-charm) settings.

No existing facade APIs or params structs are changed.

QA steps

basic smoke test
@wallyworld
Owner

wallyworld commented Dec 11, 2017

!!build!!
@babbageclunk

babbageclunk approved these changes Dec 11, 2017
View changes

Looks good!

@wallyworld
Owner

wallyworld commented Dec 11, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Dec 11, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit 09a7ce5 into juju:develop Dec 11, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment