/juju

Caas firewaller #8202

Merged
merged 7 commits into from Dec 11, 2017

Conversation

Reviewers

@axw axw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@wallyworld @jujubot @axw
@wallyworld
Owner

wallyworld commented Dec 11, 2017

Description of change

Supersedes #8193

Add caas firewaller worker and facades.
Broken up into a few commits.

QA steps

deploy caas charm
juju expose
-> check ingress
juju unexpose
-> check ingress

@wallyworld wallyworld referenced this pull request Dec 11, 2017

Closed

Add caas firewaller #8193

@axw

axw approved these changes Dec 11, 2017
View changes

LGTM, assuming the ExposeService and UnexposeService methods are already idempotent. If not, please make them so.

@wallyworld
Owner

wallyworld commented Dec 11, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Dec 11, 2017

Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju

@jujubot jujubot merged commit c6d7c7a into juju:develop Dec 11, 2017
1 check passed

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment