Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
audit-log: Include times on API requests and errors #8203
Conversation
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
jujubot
merged commit 9fe44fe
into
juju:2.3
Dec 12, 2017
1 check passed
continuous-integration/jenkins/pr-merge
This commit looks good
Details
babbageclunk
deleted the
babbageclunk:audit-when
branch
Dec 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedDec 11, 2017
Description of change
Some commands can take a non-negligible amount of time, so it's useful to know when the API requests are happening. Add a timestamp to request and error records. (Previously only the top-level conversation record had a timestamp.)
QA steps
Run a few commands against a controller that has audit logging on. The API requests and responses will also have timestamps.