Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix model representation for bundle deployments. #8228
Conversation
| applications[name] = application | ||
| annotationTags = append(annotationTags, names.NewApplicationTag(name).String()) | ||
| appNames = append(appNames, name) | ||
| - if len(appStatus.SubordinateTo) == 0 { | ||
| + if len(appStatus.Units) > 0 { |
wallyworld
Dec 15, 2017
Owner
Reading the code, it looks like doing this will prevent any constraints associated with the app from being processed. Not sure that's a good thing.
howbazaar
Dec 15, 2017
Owner
That isn't the case here. This is only building the memory representation of the model as it exists for working out what commands to run. If the app is specified in the bundle and has constraints, the worst that will happen is that it tries to set the constraints to what they are already.
|
$$merge$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
|
Build failed: Tests failed |
|
$$try-again$$ |
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
howbazaar commentedDec 15, 2017
If there was a subordinate application that wasn't related to anything, the client would try to get application constraints for it, and error out.
QA steps
Deploy a subordinate application to a model.
Use --dry-run on any bundle deploy.
Bug reference
https://bugs.launchpad.net/juju/+bug/1736592