backport pr 8379 Fix lp:1748275 #8383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simply because the agent pinger isn't alive on the server yet.
|
|
2 similar comments
|
|
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Feb 21, 2018
Merge pull request #8404 from jameinel/2.3-into-develop ## Description of change\r\n\r\nBrings in changes from 2.3 that weren't in develop.\r\n * Merge pull request #8400 from wallyworld/fix-image-metadata-cache\r\n * Merge pull request #8383 from hmlanigan/bug1748275\r\n * Merge pull request #8395 from manadart/2.3-bug-1748381-test-fix\r\n * Merge pull request #8389 from Veebers/sync-ci-from-develop\r\n\r\n## QA steps\r\n\r\nSee individual patches.\r\n\r\n## Documentation changes\r\n\r\nNone.\r\n\r\n## Bug reference\r\n\r\n[lp:1748275](https://bugs.launchpad.net/bugs/1748275)\r\n[lp:1748381](https://bugs.launchpad.net/bugs/1748381)\r\n[lp:1724210](https://bugs.launchpad.net/bugs/1724210)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
If you run juju enable-ha very quickly, e.g. via script, after bootstrap has completed, there is a window of time where the controller hasn't sent a ping yet to agent presence. In this case, it's possible that
EnableHA will demote the server it's running on as part of the enablement process, causing another server to be provisioned.
QA steps
Best bet is to find a cloud this is easily reproducible on to run. It can be difficult to reproduce.
$ juju bootstrap localhost test ; juju enable-ha -c test
Documentation changes
n/a
Bug reference
https://bugs.launchpad.net/juju/+bug/1748275