/juju

fix dependencies.tsv #980

Merged
merged 1 commit into from Oct 28, 2014

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@natefinch @jujubot
@natefinch
Contributor

natefinch commented Oct 28, 2014

turns out that if you do this:
GOOS=windows godeps -t ./... > dependencies.tsv
that you get the right dependencies, since windows dependencies are a strict
superset of linux dependencies. This may not always be true, but it is right
now, and that's good enough for me.
This fixes bug https://bugs.launchpad.net/juju-core/+bug/1384818

http://reviews.vapour.ws/r/277/
@natefinch
fix dependencies.tsv 
turns out that if you do this:
GOOS=windows godeps -t ./... > dependencies.tsv
that you get the right dependencies, since windows dependencies are a strict
superset of linux dependencies.  This may not always be true, but it is right
now, and that's good enough for me.
436bc59
@natefinch
Contributor

natefinch commented Oct 28, 2014

$$merge$$ JFDI
@jujubot
Contributor

jujubot commented Oct 28, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Oct 28, 2014

@jujubot
Merge pull request #980 from natefinch/fix_deps_again 
fix dependencies.tsv

turns out that if you do this:
GOOS=windows godeps -t ./... > dependencies.tsv
that you get the right dependencies, since windows dependencies are a strict
superset of linux dependencies.  This may not always be true, but it is right
now, and that's good enough for me.
This fixes bug https://bugs.launchpad.net/juju-core/+bug/1384818

http://reviews.vapour.ws/r/277/
ca3406f

@jujubot jujubot merged commit ca3406f into juju:master Oct 28, 2014

@natefinch natefinch referenced this pull request Oct 28, 2014

Closed

fix dependencies.tsv #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment