/loggo

Protect write operations with a muxtex #18

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wallyworld @jujubot
@wallyworld
Owner

wallyworld commented Aug 3, 2016 •
Edited 1 time

https://bugs.launchpad.net/juju-core/+bug/1609041

Juju CI tests were showing a race. I couldn't reproduce locally, but what appears to be happening is that:

  1. getWriters() which is protected by a mutex gives the writers
  2. however, there's nothing preventing concurrent writes to each writer

So I added a new mutex to protect the write() api itself.

(Review request: http://reviews.vapour.ws/r/5358/)
@wallyworld
Owner

wallyworld commented Aug 3, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-loggo

@jujubot jujubot merged commit 58055bd into juju:master Aug 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment