New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect write operations with a muxtex #18

Merged

jujubot merged 1 commit into juju:master from wallyworld:fix-race

Aug 3, 2016

Member

wallyworld commented Aug 3, 2016 •

edited

https://bugs.launchpad.net/juju-core/+bug/1609041

Juju CI tests were showing a race. I couldn't reproduce locally, but what appears to be happening is that:

getWriters() which is protected by a mutex gives the writers
however, there's nothing preventing concurrent writes to each writer

So I added a new mutex to protect the write() api itself.

(Review request: http://reviews.vapour.ws/r/5358/)


          Protect write operations with a muxtex

76353df

Member Author

wallyworld commented Aug 3, 2016

$$merge$$

Contributor

jujubot commented Aug 3, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-loggo

jujubot merged commit 58055bd into juju:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment