Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
names: add StorageTag #37
Conversation
dimitern
reviewed
Jan 20, 2015
| +} | ||
| + | ||
| +func (s *storageSuite) TestStorageNameValidity(c *gc.C) { | ||
| + assertStorageNameValid(c, "store/0") |
dimitern
Jan 20, 2015
Contributor
I'd add a couple of valid cases (with actual names you plan to use) to illustrate "store" is not required, as it got me confused initially.
|
LGTM |
added a commit
that referenced
this pull request
Jan 20, 2015
axw
merged commit f2761fa
into
juju:master
Jan 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
axw commentedJan 20, 2015
A new kind of tag is added for referring to storage instances;
these are instances of charm storage. The format is "storage/N",
where "storage" is the name defined in charm storage metadata
and "N" is a unique sequence number.