/names

Add FilesystemTag #41

Merged
merged 2 commits into from Feb 20, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@wallyworld @axw
@wallyworld
Owner

wallyworld commented Feb 19, 2015

Add support for a Filesystem tag.
For maximum flexibility, the tag id is allowed to be any valid directory name. This is because in Juju, when no location is specified when creating a fs mount, the mount point is created from the tag id.

@wallyworld wallyworld referenced this pull request in juju/juju Feb 19, 2015

Merged

Add support for file system storage sources, and rootfs provider #1626

@axw
Member

axw commented Feb 20, 2015

I'm not really keen on having such a broad definition for the tag. Why not just use a number, like in other places? Having a broad definition makes it difficult to impossible to encode additional information later, if necessary.

Also, I think we'll probably want to have an optional machine component like in volume tags, to indicate that the filesystem is tied to that machine.
@axw
Member

axw commented Feb 20, 2015

LGTM

wallyworld added a commit that referenced this pull request Feb 20, 2015

@wallyworld
Merge pull request #41 from juju/filesystem-tag 
Add FilesystemTag
ce4ecb2

@wallyworld wallyworld merged commit ce4ecb2 into master Feb 20, 2015

jujubot added a commit to juju/juju that referenced this pull request Feb 23, 2015

@jujubot
Merge pull request #1626 from wallyworld/rootfs-storage-provider 
Add support for file system storage sources, and rootfs provider

Requires juju/names#41

Add a rootfs storage provider (ported from storage feature branch with changes to accommodate new data model). When writing the tests, it was discovered that the current loop provider tests were broken. These were fixed as well. The issue is that a different gc.C is used in each and every test and is different from that used during test and suite set up. So the mockCommand struct needed to have the gc.C set in each test.

(Review request: http://reviews.vapour.ws/r/956/)
2ba3166

@wallyworld wallyworld deleted the filesystem-tag branch May 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment