Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Allow V3 charm urls in tags #74
Conversation
macgreagoir
reviewed
Sep 20, 2016
A couple of minor comments about the test comments, but nothing to block the change. lgtm.
| @@ -17,6 +17,7 @@ type charmSuite struct{} | ||
| var _ = gc.Suite(&charmSuite{}) | ||
| var validCharmURLs = []string{"charm", | ||
| + // Old-style charm urls. |
macgreagoir
Sep 20, 2016
Contributor
These are V1, is that right? If so, maybe we should note them as such here for future clarity.
babbageclunk
Sep 20, 2016
Member
Good points, thanks! I've been annoyed by references to the "old" and "new" formats in other charm url code, so it'd be good not to make the same mistake here. :)
| @@ -37,6 +39,25 @@ var validCharmURLs = []string{"charm", | ||
| "charm-1", | ||
| "series/charm", | ||
| "series/charm-1", | ||
| + | ||
| + // New-style charm urls. |
macgreagoir
Sep 20, 2016
Contributor
Same as "Old-style", probably good to also note "New-style" as V3 here. Nothing is new for long :-)
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-names |
jujubot
merged commit 5b44e2c
into
juju:v2
Sep 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
babbageclunk commentedSep 20, 2016
Previously charm urls needed to have the format:
cs:~user/series/name-revisionNow they can also have the format:
cs:user/name/series/revisionThe old form is still accepted for backwards compatibility reasons.
Part of http://pad.lv/1584193