/persistent-cookiejar

revert back to file-based locking; increase timeout #21

Merged
merged 1 commit into from Nov 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rogpeppe @mhilton @voidspace
@rogpeppe
Owner

rogpeppe commented Nov 15, 2016 •
Edited 1 time

We want to use file-based locking because we're locking a file.
Non-file-based locking can't work when locking
on a shared filesystem.

We also increase the timeout to because some users have
reported timeout errors.
@rogpeppe
revert back to file-based locking; increase timeout 
We want to use file-based locking because we're locking a file,
Non-file-based locking can't work when locking
on a shared filesystem.

We also increase the timeout to because some users have
reported timeout errors.
62d3976
@mhilton
Member

mhilton commented Nov 15, 2016

assuming you want to revert the change, then this looks like a good way to do it. LGTM
@voidspace
Contributor

voidspace commented Nov 15, 2016

LGTM

@rogpeppe rogpeppe merged commit 5243747 into juju:master Nov 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment