Added setup.py #75

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Contributor

petevg commented Dec 21, 2016

Makes it possible to add plugins as a depedency to another project (for
example, gh:juju-solutions/matrix, which is what prompted this
change).

The setup.py puts all the scripts in Python's bin dir, naturally adding
them to the path in your current Python environment.

@johnsca

@petevg petevg referenced this pull request in juju-solutions/matrix Dec 21, 2016

Closed

Feature Request: Include capability to collect debug logs #17

Added setup.py
Makes it possible to add plugins as a depedency to another project (for
example, gh:juju-solutions/matrix, which is what prompted this
change).

The setup.py puts all the scripts in Python's bin dir, naturally adding
them to the path in your current Python environment.
Member

johnsca commented Jan 30, 2017

+1 this makes it easier to manage the path, though I'd also like to see this grow a snap.yaml as well.

Owner

marcoceppi commented Jan 31, 2017

Contributor

petevg commented Jan 31, 2017

@marcoceppi the cwr-ci bundle wants to run juju-crashdump in order to gather logs from a test run. @johnsca also wants to drop it into bundletester. It's a useful bit of functionality.

I can drop the code from the juju-crashdump script into both matrix and bundletester, but the script is kind of inherently tricky, and I'd rather not be maintaining a tricky, oft patched script in two different places. :-/

Owner

marcoceppi commented Jan 31, 2017

The general guideance has been, if it requires a set of deps or more complexity than a one off script, it should be it's own project. This is what juju-wait and others have done, I'd recommend this route for this plugin.

Think of the plugins repo as an incubation project, it sounds like this plugin has just graduated.

Contributor

petevg commented Jan 31, 2017

@marcoceppi That sounds sensible. I will move it into its own space.

@petevg petevg closed this Jan 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment