Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Model.add_machines() #51

Closed
tvansteenburgh opened this issue Jan 31, 2017 · 0 comments · Fixed by #56
Closed

Implement Model.add_machines() #51

tvansteenburgh opened this issue Jan 31, 2017 · 0 comments · Fixed by #56
Assignees
@tvansteenburgh
Labels
high medium

Comments

@tvansteenburgh
Copy link
Contributor

We have BundleHandler.addMachines() but that's not a public api. Maybe the logic can be relocated to Model.add_machines() and then BundleHandler.addMachines() can call that.
tvansteenburgh added a commit that referenced this issue Feb 21, 2017
@tvansteenburgh
Implement Model.add_machine()
5fef750 
Also fixes a bug that was causing the 'to' parameter to
Model.deploy() to not be handled correctly.

Add docs and examples for adding machines and containers
and deploying charms to them.

Fixes #51.
@tvansteenburgh tvansteenburgh mentioned this issue Feb 21, 2017
Merged
@tvansteenburgh tvansteenburgh self-assigned this Feb 23, 2017
tvansteenburgh added a commit that referenced this issue Feb 24, 2017
@tvansteenburgh
Merge pull request #56 from /issues/51
afb309d 
Implement Model.add_machine()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tvansteenburgh tvansteenburgh

Labels
high medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Model.add_machine() juju/python-libjuju
2 participants
@tvansteenburgh @arosales