Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Workaround or missing redirect_info in JaaS. #113
Conversation
petevg
referenced this pull request
in juju-solutions/matrix
Apr 26, 2017
Merged
Feature/jaas support v2 #127
|
I created a more comprehensive refactor in #116 which I'd like to close this PR in favor of if it looks ok to you. |
|
Agree that @johnsca's refactor is more comprehensive. Closing this out ... |
petevg
closed this
Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
petevg commentedApr 26, 2017
JaaS deployments were throwing a JujuAPIError because the JaaS
controller does not appear to have implemented redirect_info.
Dropped in a change to catch the error and ignore it in that case.
@tvansteenburgh @johnsca I'm not sure how to test JaaS stuff effectively. To validate that my code works, you can run examples/add_model.py, after editing the file to pass
cloud_name="aws"into the call to .add_model.(Without this change, add_model will fail due to a JujuAPIErrror.)