Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Refactored login code to better handle redirects #116
Conversation
johnsca
referenced this pull request
Apr 26, 2017
Closed
Workaround or missing redirect_info in JaaS. #113
johnsca
merged commit 7c2a530
into
master
Apr 26, 2017
|
Can we get a new version pushed to pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
johnsca commentedApr 26, 2017
•
Edited 1 time
-
johnsca
Apr 26, 2017
Fixes #114: build_facades not handling discharge-required results
Fixes #115: JAAS update broke controller connections
Also ensures that the receiver and pinger tasks get cleaned up properly when a connection is closed.
Also makes the model AllWatcher share the model connection to reduce the number of open connections required. The independent connection is no longer needed since the websocket responses are properly paired with the requests. (The secondary connection was causing additional authentication errors, for some reason.)