Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #519 and #522: Add local resources for bundles #520

Merged
merged 1 commit into from Aug 24, 2021
Merged

Fix bug #519 and #522: Add local resources for bundles #520

merged 1 commit into from Aug 24, 2021

Conversation

davigar15
Copy link
Contributor

No description provided.

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

17 similar comments
@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

@jujubot
Copy link
Contributor

jujubot commented Aug 19, 2021

Can one of the admins verify this patch?

Copy link
Member

@SimonRichardson SimonRichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks in line with what juju does. Just add a test and I'll happily land this.

@SimonRichardson
Copy link
Member

!!build!!

1 similar comment
@SimonRichardson
Copy link
Member

!!build!!

@davigar15 davigar15 changed the title Fix bug #519: Get default series in k8s bundles Fix bug #519 and #522: Add local resources for bundles Aug 20, 2021
@SimonRichardson
Copy link
Member

!!build!!

1 similar comment
@SimonRichardson
Copy link
Member

!!build!!

@SimonRichardson
Copy link
Member

!!build!!

2 similar comments
@hpidcock
Copy link
Member

!!build!!

@SimonRichardson
Copy link
Member

!!build!!

Fixes bug 522 and bug 519
@SimonRichardson
Copy link
Member

!!build!!

@SimonRichardson
Copy link
Member

!!build!!

1 similar comment
@SimonRichardson
Copy link
Member

!!build!!

@SimonRichardson
Copy link
Member

$$merge$$

@jujubot jujubot merged commit 88a752b into juju:master Aug 24, 2021
SimonRichardson added a commit to SimonRichardson/python-libjuju that referenced this pull request Oct 12, 2021
2.9.4
^^^^^

Tuesday October 12 2021

* Charmhub deploy charm by @SimonRichardson in juju#483
* add wait_for_status instead of wait_for_active by @sed-i in juju#517
* Adds resource support for charmhub deployments by @tlm in juju#516
* Fix bug juju#519 and juju#522: Add local resources for bundles by @davigar15 in juju#520
* Patching some missing kwargs by @cderici in juju#527
* Implementing `backup` functionality by @cderici in juju#536
* Fix issue 532: Set the default_series properly by @davigar15 in juju#533
* A random small bug fix by @cderici in juju#541
* Allow ApplicationFacade set_config with non-string values by @cderici in juju#540
* Skip macaroon tests issue 534 by @cderici in juju#542
* Fix issue 530: Check the controller for unsynched models by @cderici in juju#539
* Upgrade setup-python action. by @juanmanuel-tirado in juju#543
* Fix integration tests by @cderici in juju#544
* Bring juju/juju.py into life by @cderici in juju#546
* Extract resources info from apps in locally deployed bundle by cderici in juju#552
* Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com/juju/pull/558
* Fix integration tests continued by @cderici in ttps://github.com/juju/pull/547
* Get the config dir resolve logic into one place by @cderici in ttps://github.com/juju/pull/555
* Complete the backups functionality by @cderici in ttps://github.com/juju/pull/556
jujubot added a commit that referenced this pull request Oct 12, 2021
#561

2.9.4
^^^^^

Tuesday October 12 2021

* Charmhub deploy charm by @SimonRichardson in #483
* add wait_for_status instead of wait_for_active by @sed-i in #517
* Adds resource support for charmhub deployments by @tlm in #516
* Fix bug #519 and #522: Add local resources for bundles by @davigar15 in #520
* Patching some missing kwargs by @cderici in #527
* Implementing `backup` functionality by @cderici in #536
* Fix issue 532: Set the default_series properly by @davigar15 in #533
* A random small bug fix by @cderici in #541
* Allow ApplicationFacade set_config with non-string values by @cderici in #540
* Skip macaroon tests issue 534 by @cderici in #542
* Fix issue 530: Check the controller for unsynched models by @cderici in #539
* Upgrade setup-python action. by @juanmanuel-tirado in #543
* Fix integration tests by @cderici in #544
* Bring juju/juju.py into life by @cderici in #546
* Extract resources info from apps in locally deployed bundle by cderici in #552
* Fix for simple bug in bundle deployment code self.charm -> self['charm'] by @jnsgruk in ttps://github.com//pull/558
* Fix integration tests continued by @cderici in ttps://github.com//pull/547
* Get the config dir resolve logic into one place by @cderici in ttps://github.com//pull/555
* Complete the backups functionality by @cderici in ttps://github.com//pull/556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants