/romulus

Use new jujuclient store for model info and refactor tests #11

Merged
merged 2 commits into from Feb 23, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@wallyworld @cmars @tasdomas @jujubot
@wallyworld
Owner

wallyworld commented Feb 23, 2016

The old configstore is replaced by the jujuclient store.
Test are refactored to use the in memory store to avoid writes to disk.
@cmars
Owner

cmars commented Feb 23, 2016

Thanks for this! LGTM, but I'd like @tasdomas to take a look.
@tasdomas
Member

tasdomas commented Feb 23, 2016

LGTM
@cmars
Owner

cmars commented Feb 23, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Feb 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-romulus
@jujubot
Contributor

jujubot commented Feb 23, 2016

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-romulus/3
@cmars
Owner

cmars commented Feb 23, 2016

$$merge$$ now with dependencies that will pass the tests.
@jujubot
Contributor

jujubot commented Feb 23, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-romulus

jujubot added a commit that referenced this pull request Feb 23, 2016

@jujubot
Merge pull request #11 from juju/configstore-api-changes 
Use new jujuclient store for model info and refactor tests

The old configstore is replaced by the jujuclient store.
Test are refactored to use the in memory store to avoid writes to disk.
528af26

@jujubot jujubot merged commit 528af26 into master Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment