Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update testing.Clock to improve robustness #113
Conversation
| "sync" | ||
| "time" | ||
| + gc "gopkg.in/check.v1" | ||
| + | ||
| "github.com/juju/testing" |
reedobrien
Sep 30, 2016
Contributor
As discussed in person at the sprint, this conforms with how block are separated in juju/cmd and other libraries outside of juju/juju. Also, it is how goimports auto formats imports. :)
| + } | ||
| + time.Sleep(pause) | ||
| + } | ||
| + return errors.Errorf("no timers added after waiting %s", w.String()) |
babbageclunk
Sep 30, 2016
•
Edited 1 time
-
babbageclunk
Sep 30, 2016
Member
Edited 1 time
-
Sep 30, 2016
This needs to be updated for the n waiters change. It's probably worth saying how many waiters there were. Of course, then you'll get the irritating situation where one shows up between the last check and the report: "waiting for 10 timers, only 10 seen".
added a commit
to reedobrien/juju-testing
that referenced
this pull request
Sep 30, 2016
|
$$merge$$ |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing |
jujubot
merged commit 692d58e
into
juju:master
Sep 30, 2016
reedobrien
deleted the
reedobrien:lp/1607044_clockadvance-misses-somtimes
branch
Sep 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
reedobrien commentedSep 29, 2016
Adds a WaitAdvance method which ensures that there is something in
clock.waiting before actually advancing the time. Addtionally cause
Advance to log a debug message if it Advances time when clock.waiting
is empty.
Refs: https://bugs.launchpad.net/juju/+bug/1607044
QA: