/testing

Fix PatchExecutableAsEchoArgs on Windows #124

Merged
merged 1 commit into from Apr 28, 2017
+11 −27

Conversation

Reviewers

@babbageclunk babbageclunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@axw @jujubot @babbageclunk
@axw
Member

axw commented Apr 28, 2017

In the Windows echo-args script, we were
still using the relative path for .out and
.exitcodes files. Use %~f0 to get the full
path to the script.

Also, write the .exitcodes file to the
correct location, and remove the AddCleanup
calls (which were cleaning up temporary
files that will be removed by gocheck.)
@axw
Fix PatchExecutableAsEchoArgs on Windows 
In the Windows echo-args script, we were
still using the relative path for .out and
.exitcodes files. Use %~f0 to get the full
path to the script.

Also, write the .exitcodes file to the
correct location, and remove the AddCleanup
calls (which were cleaning up temporary
files that will be removed by gocheck.)
This commit was signed with a verified signature.
@axw axw Andrew Wilkins
GPG key ID: 55314F7628952B05 Learn about signing commits
cb2d77b
@babbageclunk

babbageclunk approved these changes Apr 28, 2017
View changes

Looks great!

@axw
Member

axw commented Apr 28, 2017

$$merge$$
@jujubot
Contributor

jujubot commented Apr 28, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing

@jujubot jujubot merged commit 26eb180 into juju:master Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment