/testing

testing: do not use default writer in LoggingSuite #69

Merged
merged 1 commit into from May 19, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rogpeppe @mhilton @jujubot
@rogpeppe
Owner

rogpeppe commented May 19, 2015

Currently when testing a juju command that uses cmd.Log, the
logging test output is suppressed because the logging setup
changes the default writer. This PR changes things so that
the test logger uses a different writer so we can still see
debugging log messages in such tests.

(Review request: http://reviews.vapour.ws/r/1724/)
@mhilton
Member

mhilton commented May 19, 2015

LGTM
@rogpeppe
Owner

rogpeppe commented May 19, 2015

$$merge$$
@jujubot
Contributor

jujubot commented May 19, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing

jujubot added a commit that referenced this pull request May 19, 2015

@jujubot
Merge pull request #69 from rogpeppe/009-loggingsuite-do-not-use-defa… 
…ult-writer

testing: do not use default writer in LoggingSuite

Currently when testing a juju command that uses cmd.Log, the
logging test output is suppressed because the logging setup
changes the default writer. This PR changes things so that
the test logger uses a different writer so we can still see
debugging log messages in such tests.

(Review request: http://reviews.vapour.ws/r/1724/)
49fe9a5

@jujubot jujubot merged commit 49fe9a5 into juju:master May 19, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment