/testing

testing: add constant to detect race detector #84

Merged
merged 1 commit into from Nov 23, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Nov 23, 2015

Some juju tests need to be skipped because they do not pass under
the race detector. To simplify this, add a constant so we can do:

 if testing.RaceEnabled {
        t.Skip("skipping package test under race detector, see LP NNNNN")
 }
 // normal gocheck stub

While I'm here, fix a test failure with testing/checkers under Go 1.4+

(Review request: http://reviews.vapour.ws/r/3202/)
@davecheney
testing: add constant to detect race detector 
Some juju tests need to be skipped because they do not pass under
the race detector. To simplify this, add a constant so we can do:

     if testing.RaceEnabled {
            t.Skip("skipping package test under race detector, see LP NNNNN")
     }
     // normal gocheck stub

While I'm here, fix a test failure with testing/checkers under Go 1.4+
d4a38e1
@davecheney
Contributor

davecheney commented Nov 23, 2015

Honestly the title of this PR should be "add tautology"
@davecheney
Contributor

davecheney commented Nov 23, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Nov 23, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing

jujubot added a commit that referenced this pull request Nov 23, 2015

@jujubot
Merge pull request #84 from davecheney/add-race-check 
testing: add constant to detect race detector

Some juju tests need to be skipped because they do not pass under
the race detector. To simplify this, add a constant so we can do:

     if testing.RaceEnabled {
            t.Skip("skipping package test under race detector, see LP NNNNN")
     }
     // normal gocheck stub

While I'm here, fix a test failure with testing/checkers under Go 1.4+

(Review request: http://reviews.vapour.ws/r/3202/)
3a42024

@jujubot jujubot merged commit 3a42024 into juju:master Nov 23, 2015

@davecheney davecheney deleted the davecheney:add-race-check branch Nov 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment