/testing

testing: add GOVERSION constant #85

Merged
merged 1 commit into from Nov 27, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@davecheney @jujubot
@davecheney
Contributor

davecheney commented Nov 27, 2015

Add a constant that can be used to conditionally skip tests. eg.

if testing.GOVERSION == 1.5 {
      t.Skip("skipping package, see LP NNN")
}

Additional note: GOVERSION is an untyped constant, not an IEEE floating
point value. It is safe to do comparisons on it like equals and greater
than/less than without concerns about precision.

(Review request: http://reviews.vapour.ws/r/3257/)
@davecheney
testing: add GOVERSION constant 
Add a constant that can be used to conditionally skip tests. eg.

    if testing.GOVERSION == 1.5 {
          t.Skip("skipping package, see LP NNN")
    }

Additional note: GOVERSION is an untyped constant, not an IEEE floating
point value. It is safe to do comparisons on it like equals and greater
than/less than without concerns about precision.
66b3ddd
@davecheney
Contributor

davecheney commented Nov 27, 2015

$$merge$$
@jujubot
Contributor

jujubot commented Nov 27, 2015

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing

jujubot added a commit that referenced this pull request Nov 27, 2015

@jujubot
Merge pull request #85 from davecheney/add-goversion-marker 
testing: add GOVERSION constant

Add a constant that can be used to conditionally skip tests. eg.

    if testing.GOVERSION == 1.5 {
          t.Skip("skipping package, see LP NNN")
    }

Additional note: GOVERSION is an untyped constant, not an IEEE floating
point value. It is safe to do comparisons on it like equals and greater
than/less than without concerns about precision.

(Review request: http://reviews.vapour.ws/r/3257/)
a3cc3df

@jujubot jujubot merged commit a3cc3df into juju:master Nov 27, 2015

@davecheney davecheney deleted the davecheney:add-goversion-marker branch Nov 27, 2015

@jujubot
Contributor

jujubot commented Dec 3, 2015

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju-testing/32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment